Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose HVAC Detailed Performance Data inputs #715

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Expose HVAC Detailed Performance Data inputs #715

wants to merge 19 commits into from

Conversation

bpark1327
Copy link
Collaborator

@bpark1327 bpark1327 commented Feb 9, 2024 •
edited
Loading

Pull Request Description

Expose HVAC Detailed Performance Data so that we can accommodate cold climate heat pump performance data from the NEEP database or manufacturer's data.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • OS-HPXML git subtree has been pulled
  • 301/ES rulesets and unit tests have been updated
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Workflow tests have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI

@bpark1327 bpark1327 self-assigned this Feb 9, 2024
shorowit
shorowit reviewed Feb 21, 2024
View reviewed changes
rulesets/resources/301validator.xml Outdated Show resolved Hide resolved
tasks.rb Outdated Show resolved Hide resolved
shorowit
shorowit reviewed Feb 26, 2024
View reviewed changes
rulesets/resources/301validator.xml Show resolved Hide resolved
tasks.rb Outdated Show resolved Hide resolved
rulesets/resources/301ruleset.rb Outdated Show resolved Hide resolved
rulesets/resources/301ruleset.rb Outdated Show resolved Hide resolved
@bpark1327 bpark1327 requested a review from shorowit March 8, 2024 18:12
shorowit
shorowit reviewed Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting close, just a couple more things to do.

rulesets/resources/301validator.xml Outdated Show resolved Hide resolved
tasks.rb Show resolved Hide resolved
docs/source/workflow_inputs.rst Outdated Show resolved Hide resolved
docs/source/workflow_inputs.rst Outdated Show resolved Hide resolved
@bpark1327 bpark1327 marked this pull request as ready for review March 11, 2024 16:40
@bpark1327 bpark1327 requested a review from shorowit March 11, 2024 16:40
shorowit
shorowit approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, looks great. We're going to hold off on merging this in to master for now, but the branch can be used for any analysis projects.

@shorowit shorowit changed the title Expose HVAC Detailed Performance Data Expose HVAC Detailed Performance Data inputs Mar 26, 2024
Base automatically changed from latest-os-hpxml to master May 29, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit shorowit approved these changes

Assignees

@bpark1327 bpark1327

Labels
DO NOT MERGE enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpark1327 @shorowit